accounts/keystore: add Close method and improve finalizer documentation #32842
+86
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the TODO comment in KeyStore.init() regarding the finalizer not triggering properly due to references held by unlocked keys.
Problem:
The runtime.AddCleanup finalizer was not triggering because unlocked keys with
active timers maintain references to the KeyStore instance, preventing garbage
collection. This could lead to resource leaks where the account cache remains
open indefinitely.
Solution:
and stops their timers, allowing the finalizer to trigger correctly
Close() calls